On Wed, Jan 8, 2020 at 2:32 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > On 06-12-19, 16:24, Saravana Kannan wrote: > > Interconnects often quantify their performance points in terms of > > bandwidth. So, add opp-peak-kBps (required) and opp-avg-kBps (optional) to > > allow specifying Bandwidth OPP tables in DT. > > > > opp-peak-kBps is a required property that replaces opp-hz for Bandwidth OPP > > tables. > > > > opp-avg-kBps is an optional property that can be used in Bandwidth OPP > > tables. > > > > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx> > > Reviewed-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++--- > > .../devicetree/bindings/property-units.txt | 4 ++++ > > 2 files changed, 16 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > index 68592271461f..dbad8eb6c746 100644 > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > @@ -83,9 +83,14 @@ properties. > > > > Required properties: > > - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a > > - required property for all device nodes but devices like power domains. The > > - power domain nodes must have another (implementation dependent) property which > > - uniquely identifies the OPP nodes. > > + required property for all device nodes except for devices like power domains > > + or bandwidth opp tables. > > Fine until here. > > > The power domain nodes must have another > > + (implementation dependent) property which uniquely identifies the OPP nodes. > > + The interconnect opps are required to have the opp-peak-kBps property. > > Maybe rewrite it as: > > The devices which don't have this property must have another > (implementation dependent) property which uniquely identifies the OPP > nodes. > > So we won't be required to update this again for another property. > > > + > > +- opp-peak-kBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit > > + big-endian integer. > > > This is a required property for all devices that don't > > + have opp-hz. > > This statement is surely incorrect, isn't it ? What about power-domain > tables ? > > Suggest rewriting it as: > > This is a required property for bandwidth OPP tables. > Agree with all the suggestions. Will fix in the next version. -Saravana
