On Mon, Jan 06, 2020 at 01:03:35AM -0800, Matt Ranostay wrote: > Atlas Scientific DO-SM OEM sensor reads disolved oxygen in > a solution. This is reported back as mg/L which maps directly > to ppm and so the IIO_CONCENTRATION channel type can be used. > > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Matt Ranostay <matt.ranostay@xxxxxxxxxxxx> > --- > .../bindings/iio/chemical/atlas,do-sm.txt | 21 ++++++ Please split bindings to separate patch and make this a DT schema. It seems like all these Atlas sensors are the same. Can you combine them into one schema? > drivers/iio/chemical/atlas-sensor.c | 64 +++++++++++++++++-- > 2 files changed, 81 insertions(+), 4 deletions(-) > create mode 100644 Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > > diff --git a/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt b/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > new file mode 100644 > index 000000000000..fc741ea794c4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/chemical/atlas,do-sm.txt > @@ -0,0 +1,21 @@ > +* Atlas Scientific DO-SM OEM sensor > + > +http://www.atlas-scientific.com/_files/_datasheets/_oem/DO_oem_datasheet.pdf > + > +Required properties: > + > + - compatible: must be "atlas,do-sm" > + - reg: the I2C address of the sensor > + - interrupts: the sole interrupt generated by the device > + > + Refer to interrupt-controller/interrupts.txt for generic interrupt client > + node bindings. > + > +Example: > + > +atlas@64 { > + compatible = "atlas,do-sm"; > + reg = <0x67>; > + interrupt-parent = <&gpio1>; > + interrupts = <16 2>; > +};
