On 08/01/2020 10:25, Nicolas Boichat wrote: > On Mon, Jan 6, 2020 at 11:11 AM Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> wrote: >> >> Add reset controller API in watchdog driver. >> Besides watchdog, MTK toprgu module alsa provide sub-system (eg, audio, >> camera, codec and connectivity) software reset functionality. > > You add support for reset controller on both 8183 and 2712, do you > want to say that in the commit title and message? > I normally prefer to split that into at least two patches. Regards, Matthias >> >> Signed-off-by: yong.liang <yong.liang@xxxxxxxxxxxx> >> Signed-off-by: Jiaxin Yu <jiaxin.yu@xxxxxxxxxxxx> >> Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx> >> Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> >> --- >> drivers/watchdog/mtk_wdt.c | 105 ++++++++++++++++++++++++++++++++++++- >> 1 file changed, 104 insertions(+), 1 deletion(-)
