On Tue, Jan 7, 2020 at 1:16 PM Light Hsieh <light.hsieh@xxxxxxxxxxxx> wrote: > Use of "bias-pull-down = <MTK_PUPD_SET_R1R0_XX>" had already been > described in > Documentation/devicetree/binding/pinctrl/pinctrl-mt65xx.txt. > Previous MediaTek chips using pinctrl-mtk-common.c had already use such > binding. This is so-called backward compatibility. > > Besides, according to > Documentation/devicetree/binding/pinctrl/pincfg-node.yaml, bias-pull-up > and bias-pull-down can have an optional argument to select pull strength > when supported by hardware. That's right, I was wrong about this. This should be fine to use. > So, I think the propose of using "mediatek,pull-up-adv" and > "mediatek,pull-down-adv" is not necessary. However, I fail to stop > upstream of using "mediatek,pull-up-adv" and "mediatek,pull-down-adv" in > pinctrl-mtk-common-v2.c. Let's see what Sean says, I am fine with the patch set in general. Yours, Linus Walleij
