Re: [PATCH v2 0/2] combine bindings for simple panels in a few files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 02, 2020 at 11:17:10AM +0100, Sam Ravnborg wrote:
> This patchset introduces two files:
> 
>     panel-simple.yaml
>     panel-simple-dsi.yaml
> 
> The two files will be used for bindings for simple
> panels that have only a single power-supply.
> 
> For now only a few bindings are migrated - the
> reamining bindings will be migrated when we have agreed
> on the format.
> 
> v2:
>   - updated binding description in panel-simple.yaml
>   - fixed exampe in panel-simple.yaml
>     (I was missing libyaml-dev - now the examples are checked properly here)
>   - added panel-simple-dsi.yaml
> 
> 	Sam 
> 
> Sam Ravnborg (2):
>       dt-bindings: one binding file for all simple panels
>       dt-bindings: one file of all simple DSI panels
> 
>  .../display/panel/ampire,am-480272h3tmqw-t01h.yaml | 42 --------------
>  .../display/panel/ampire,am800480r3tmqwa1h.txt     |  7 ---
>  .../display/panel/panasonic,vvx10f034n00.txt       | 20 -------
>  .../bindings/display/panel/panel-simple-dsi.yaml   | 67 ++++++++++++++++++++++
>  .../bindings/display/panel/panel-simple.yaml       | 59 +++++++++++++++++++
>  5 files changed, 126 insertions(+), 69 deletions(-)

I like this. With the improved structure that the YAML bindings provide
this becomes rather neat. You may want to update the subject of the
patches to better reflect the style (most seem to use "dt-bindings:
display: " as prefix, for example). But overall, looks good:

Acked-by: Thierry Reding <treding@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux