On Tue, 7 Jan 2020 at 09:45, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote: > > The patch adds fimd node for tiny4412 device. > > Hi, > > Thanks for the patch. > > Do not use "This patch ..." sentences but simple, imperative mode: > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > > Here you do not add FIMD node, because the FIMD is already there > (defined in exynos4.dtsi). You however enable it. > > Enabling it without panel does not really make sense - does it work? > I guess not, so this should be squashed with second patch. ... unless it really works without panel, then it makes sense to keep it separate. However in such case, the #cells properties belong to second patch. Best regards, Krzysztof
