Hi Stefan,
On 1/3/20 9:23 AM, Stefan Wahren wrote:
> This adds the thermal sensor driver for the Broadcom BCM2711 SoC,
> which is placed on the Raspberry Pi 4. The driver only provides
> SoC temperature reading so far.
>
> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
This looks good, I just have a couple of nits that you can address since
the binding needs to be re-spun, see below, in any case:
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
[snip]
> + of_node_put(parent);
> + if (IS_ERR(regmap)) {
> + dev_err(dev, "failed to get regmap (error %ld)\n",
> + PTR_ERR(regmap));
Here we use %ld
> + return PTR_ERR(regmap);
> + }
> + priv->regmap = regmap;
> + priv->dev = dev;
> +
> + thermal = devm_thermal_zone_of_sensor_register(dev, 0, priv,
> + &bcm2711_thermal_of_ops);
> + if (IS_ERR(thermal)) {
> + ret = PTR_ERR(thermal);
> + dev_err(dev, "could not register sensor: %d\n", ret);
and here we do an implicit cast into int, thus using %d, could we just
make both consistent and use %d?
--
Florian
