On Thu, Jan 2, 2020 at 1:44 AM Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > > Hi Rob, > > On Thu, Dec 19, 2019 at 11:31 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Mon, Dec 16, 2019 at 08:49:23AM +0000, Lad, Prabhakar wrote: > > > Hi Rob, > > > > > > Thank you for the review. > > > > > > On Fri, Dec 13, 2019 at 8:37 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > > > > > > > > On Fri, Dec 13, 2019 at 2:48 AM Lad Prabhakar > > > > <prabhakar.csengg@xxxxxxxxx> wrote: > > > > > > > > > > From: "Lad, Prabhakar" <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > > > > > > > this patch adds support to parse PCI outbound-ranges, the > > > > > outbound-regions are similar to pci ranges except it doesn't > > > > > have pci address, below is the format for bar-ranges: > > > > > > > > > > outbound-ranges = <flags upper32_cpuaddr lower32_cpuaddr > > > > > upper32_size lower32_size>; > > > > > > > > You can't just make up a new ranges property. Especially one that > > > > doesn't follow how 'ranges' works. We already have 'dma-ranges' to > > > > translate device to memory addresses. > > > > > > > > Explain the problem or feature you need, not the solution you came up > > > > with. Why do you need this and other endpoint bindings haven't? > > > > > > > rcar SoC's supports multiple outbound region for mapping the PCI address > > > locally to the system. This lead to discussion where there exist controllers > > > which support regions for high/low priority transfer and similarly regions > > > for large/small memory allocations, as a result a new ranges property was > > > added, where we can specify the flags which would indicate how the outbound > > > region can be used during requests. > > > > What are the flags? > > below are the flags which were discussed in first version of the > series, but since the driver is > currently using just PCI_EPC_WINDOW_FLAG_NON_MULTI_ALLOC flag I'll be > dropping them in > next version (suggested by Kishon) and rest will be added as and when > required by the driver. > > * @PCI_EPC_WINDOW_FLAG_MULTI_ALLOC: Indicates multiple chunks of memory can be > * allocated from same window > * @PCI_EPC_WINDOW_FLAG_NON_MULTI_ALLOC: Indicates only single memory allocation > * is possible on the window > * @PCI_EPC_WINDOW_FLAG_LARGE_ALLOC: Window is used for large memory allocation > * @PCI_EPC_WINDOW_FLAG_SMALL_ALLOC: Window is used for small memory allocation > * @PCI_EPC_WINDOW_FLAG_HIGH_PRI_ALLOC: Window is used for high priority data > * transfers > * @PCI_EPC_WINDOW_FLAG_LOW_PRI_ALLOC: Window is used for low priority data > * transfers Looks like configuration or policy, not something that belongs in DT. Coupling driver features and DT changes is not good for ABI compatible changes either. I'm hesitant to accept any PCI endpoint binding additions because they don't seem to be completely thought out in terms of supporting different usecases. Rob
