Hi Geert. On Thu, Jan 02, 2020 at 03:12:44PM +0100, Geert Uytterhoeven wrote: > Document support for the Okaya RH128128T display, which is a 128x128 > 1.44" TFT display driven by a Sitronix ST7715R TFT Controller/Driver. > > ST7715R and ST7735R are very similar. Their major difference is that > the former is restricted to displays of up to 132x132 pixels, while the > latter supports displays up to 132x162 pixels. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > .../devicetree/bindings/display/sitronix,st7735r.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt > index cd5c7186890a2be7..87ebdcb294e29798 100644 > --- a/Documentation/devicetree/bindings/display/sitronix,st7735r.txt > +++ b/Documentation/devicetree/bindings/display/sitronix,st7735r.txt While touching the bindings file, can I convince you to convert it to meta-schema format (.yaml)? > @@ -4,7 +4,9 @@ This binding is for display panels using a Sitronix ST7735R controller in SPI > mode. > > Required properties: > -- compatible: "jianda,jd-t18003-t01", "sitronix,st7735r" > +- compatible: Must be one of the following combinations: > + - "jianda,jd-t18003-t01", "sitronix,st7735r" > + - "okaya,rh128128t", "sitronix,st7715r" It would be nice if there was a "description" for each pair of compatible that identified the actual panel. In your case "Okaya RH128128T 1.44" 128x128 TFT display" It can be looked up in git history - but better to have it in the binding file. Sam
