On 07.05.2014 14:00, Shaik Ameer Basha wrote: > Hi Tomasz, > > On Tue, May 6, 2014 at 11:19 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: >> Shaik, >> >> >> On 06.05.2014 18:26, Shaik Ameer Basha wrote: >>> >>> This patch adds some missing miscellaneous clocks specific >>> to exynos5420. >>> >>> Signed-off-by: Rahul Sharma <rahul.sharma@xxxxxxxxxxx> >>> Signed-off-by: Shaik Ameer Basha <shaik.ameer@xxxxxxxxxxx> >>> --- >>> drivers/clk/samsung/clk-exynos5420.c | 14 +++++++++++--- >>> include/dt-bindings/clock/exynos5420.h | 2 ++ >>> 2 files changed, 13 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/clk/samsung/clk-exynos5420.c >>> b/drivers/clk/samsung/clk-exynos5420.c >>> index e0e749d..e69e820 100644 >>> --- a/drivers/clk/samsung/clk-exynos5420.c >>> +++ b/drivers/clk/samsung/clk-exynos5420.c >>> @@ -273,7 +273,8 @@ PNAME(mout_group5_p) = {"mout_sclk_vpll", >>> "mout_sclk_dpll"}; >>> >>> PNAME(mout_fimd1_final_p) = {"mout_fimd1", "mout_fimd1_opt"}; >>> PNAME(mout_sw_aclk66_p) = {"dout_aclk66", "mout_sclk_spll"}; >>> -PNAME(mout_user_aclk66_peric_p) = { "fin_pll", "mout_sw_aclk66" }; >>> +PNAME(mout_user_aclk66_peric_p) = { "fin_pll", "mout_sw_aclk66"}; >>> +PNAME(mout_user_pclk66_gpio_p) = {"mout_sw_aclk66", "ffactor_sw_aclk66"}; >>> >>> PNAME(mout_sw_aclk200_fsys_p) = {"dout_aclk200_fsys", "mout_sclk_spll"}; >>> PNAME(mout_sw_pclk200_fsys_p) = {"dout_pclk200_fsys", "mout_sclk_spll"}; >>> @@ -372,10 +373,13 @@ static struct samsung_fixed_rate_clock >>> exynos5420_fixed_rate_clks[] __initdata = >>> }; >>> >>> static struct samsung_fixed_factor_clock exynos5420_fixed_factor_clks[] >>> __initdata = { >>> - FFACTOR(0, "sclk_hsic_12m", "fin_pll", 1, 2, 0), >>> + FFACTOR(0, "ffactor_hsic_12m", "fin_pll", 1, 2, 0), >>> + FFACTOR(0, "ffactor_sw_aclk66", "mout_sw_aclk66", 1, 2, 0), >> >> >> Is the "ffactor_" prefix also present in the datasheet? If not, it should be >> removed from clock names as well. > > Its not there in manual. > As we are differentiating muxes and dividers with "mout" and "dout" > this prefix is added > to differentiate fixed factor clocks. > > shall I keep it or not? mout and div prefixes are also used in documentation, at least in case of previous Exynos SoCs. In case of Exynos5420 I can see CLKDIV_ prefix used for dividers, so after stripping the CLK part which is simply redundant, we are left with div_ prefix as in Exynos4 - not sure why in Exynos5420 driver dout_ prefix was used, I must have missed that in review, but I simply didn't have any the documentation for this chip at that time. I don't see those hsic_12m and sw_aclk66 clocks in my version of the datasheet (probably an old version) so I can't say what would be the proper names for both, but I wouldn't add ffactor_ there. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html