On 7 May 2014 11:45, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> On Wed, Dec 18, 2013 at 02:43:18PM +0000, Sascha Hauer wrote:
>> Some rotary encoders have a stable state in all output state
>> combinations. Add support for this type of encoder.
>>
>> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
>> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>> Cc: Daniel Mack <daniel@xxxxxxxxxx>
>> Cc: linux-input@xxxxxxxxxxxxxxx
>> Cc: devicetree@xxxxxxxxxxxxxxx
>> ---
>> .../devicetree/bindings/input/rotary-encoder.txt | 1 +
>> Documentation/input/rotary-encoder.txt | 9 +++++--
>> drivers/input/misc/rotary_encoder.c | 30 ++++++++++++++++++++--
>> include/linux/rotary_encoder.h | 1 +
>> 4 files changed, 37 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/input/rotary-encoder.txt b/Documentation/devicetree/bindings/input/rotary-encoder.txt
>> index 3315495..cbdb29b 100644
>> --- a/Documentation/devicetree/bindings/input/rotary-encoder.txt
>> +++ b/Documentation/devicetree/bindings/input/rotary-encoder.txt
>> @@ -15,6 +15,7 @@ Optional properties:
>> - rotary-encoder,rollover: Automatic rollove when the rotary value becomes
>> greater than the specified steps or smaller than 0. For absolute axis only.
>> - rotary-encoder,half-period: Makes the driver work on half-period mode.
>> +- rotary-encoder,quarter-period: Makes the driver work on quarter-period mode.
>
> The new property looks as sane to me as the half-period property, so for
> the binding addition:
>
> Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
>
Thanks!
> As a general nitpick it would be nicer if the binding didn't refer to
> the driver and had a description of {half,quarter} period modes inline,
> but that might be a bit tricky and shouldn't block this.
>
I can submit a follow-up patch to clean the binding. It shouldn't be
too hard to re-phrase
the properties so it's clear it's a hardware property.
Dmitry, Do you think you can merge this for v3.16? I've posted a
completely equivalent
patch a while ago [1], which was acked by Daniel, but it was never
merged. Sascha's patch
looks fine as well:
Acked-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxxxxxxxxx>
[1] https://lkml.org/lkml/2013/10/4/167
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
