Dear Felipe Balbi, On Tue, 6 May 2014 10:39:53 -0500, Felipe Balbi wrote: > > config USB_EHCI_HCD > > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile > > index 7530468c9a4f..7a8db7f7dc01 100644 > > --- a/drivers/usb/host/Makefile > > +++ b/drivers/usb/host/Makefile > > @@ -19,6 +19,7 @@ xhci-hcd-$(CONFIG_PCI) += xhci-pci.o > > > > ifneq ($(CONFIG_USB_XHCI_PLATFORM), ) > > xhci-hcd-y += xhci-plat.o > > + xhci-hcd-$(CONFIG_USB_XHCI_MVEBU) += xhci-mvebu.o > > hmm, this has the potential of resulting in: > > xhci-hcd-m += xhci-mvebu.o > > I guess it's best to turn this into: > > ifneq ($(CONFIG_USB_XHCI_PLATFORM), ) > xhci-hcd-y += xhci-mvebu.o > endif I guess you meant: ifneq ($(CONFIG_USB_XHCI_MVEBU), ) xhci-hcd-y += xhci-mvebu.o endif Right? If so, then what about instead making CONFIG_USB_XHCI_MVEBU a bool instead of a tristate? It's more an option for the xhci-platform driver than an additional separate module, IMO. What do you think? Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
