On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote: > Convert QCOM watchdog timer bindings to DT schema format using > json-schema. > > Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ----------- > .../bindings/watchdog/qcom-wdt.yaml | 47 +++++++++++++++++++ > 2 files changed, 47 insertions(+), 28 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt > create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > new file mode 100644 > index 000000000000..4a42f4261322 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer > + > +maintainers: > + - Andy Gross <agross@xxxxxxxxxx> > + > +properties: > + compatible: > + oneOf: > + - const: qcom,kpss-timer > + - const: qcom,kpss-wdt > + - const: qcom,kpss-wdt-apq8064 > + - const: qcom,kpss-wdt-ipq4019 > + - const: qcom,kpss-wdt-ipq8064 > + - const: qcom,kpss-wdt-msm8960 > + - const: qcom,scss-timer An 'enum' is better than oneOf+const. > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + timeout-sec: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Contains the watchdog timeout in seconds. If unset, the > + default timeout is 30 seconds. Include watchdog.yaml and don't redefine this. > + > +required: > + - compatible > + - reg > + - clocks > + > +examples: > + - | > + watchdog@208a038 { > + compatible = "qcom,kpss-wdt-ipq8064"; > + reg = <0x0208a038 0x40>; > + clocks = <&sleep_clk>; > + timeout-sec = <10>; > + }; > --- > > I have added Andy as the maintainer here since the get_maintainer script > showed him. If he is not happy, then I can change it to Bjorn probably and > again if he is not happy ;-) then I will add myself or whoever they suggest. Add yourself. Rob