I will raise the next patchset with the comments addressed. > -----Original Message----- > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Sent: Wednesday, December 11, 2019 12:51 PM > To: Rakesh Pillai <pillair@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module > device node > > On Wed 04 Dec 00:48 PST 2019, Rakesh Pillai wrote: > > > Add device node for the ath10k SNOC platform driver probe > > and add resources required for WCN3990 on sc7180 soc. > > > > Signed-off-by: Rakesh Pillai <pillair@xxxxxxxxxxxxxx> > > --- > > This change is dependent on the below set of changes > > arm64: dts: sc7180: Add qupv3_0 and qupv3_1 > (https://lore.kernel.org/patchwork/patch/1150367/) > > Why? The mentioned series of patchset brings the DTSI for sc7180. Hence the addition of wifi node is dependent on this series https://lore.kernel.org/patchwork/patch/1150367/ > > > --- > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 4 ++++ > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > > 2 files changed, 31 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > index 189254f..8a6a760 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > > @@ -248,6 +248,10 @@ > > status = "okay"; > > }; > > > > +&wifi { > > + status = "okay"; > > Please conclude on the representation of the "skip-hyp-mem-assign" and > add it here, rather than in a subsequent patch - which implies that this > patch doesn't work on its own. Sure, I will update the next patchset. > > > +}; > > + > > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > > > &qup_i2c2_default { > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > index 666e9b9..40c9971 100644 > > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > > @@ -42,6 +42,12 @@ > > compatible = "qcom,cmd-db"; > > no-map; > > }; > > + > > + wlan_fw_mem: wlan_fw_region@93900000 { > > wlan_fw_mem: memory@93900000 { > > > + compatible = "removed-dma-pool"; > > + no-map; > > + reg = <0 0x93900000 0 0x200000>; > > + }; > > }; > > > > cpus { > > @@ -1119,6 +1125,27 @@ > > #clock-cells = <1>; > > }; > > }; > > + > > + wifi: wifi@18800000 { > > + status = "disabled"; > > + compatible = "qcom,wcn3990-wifi"; > > + reg = <0 0x18800000 0 0x800000>; > > + reg-names = "membase"; > > + interrupts = > > + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 > */ >, > > + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 > */ >, > > + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 > */ >, > > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 > */ >, > > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 > */ >, > > + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 > */ >, > > + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 > */ >, > > + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 > */ >, > > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 > */ >, > > + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 > */ >, > > + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 > */>, > > + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 > */>; > > + memory-region = <&wlan_fw_mem>; > > No iommus in sc7180? > > Regards, > Bjorn > > > + }; > > }; > > > > timer { > > -- > > 2.7.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
