On Wed, Dec 18, 2019 at 7:24 AM Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> wrote: > > Convert qcom,msm8916-venus Venus binding to DT schema > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > --- > .../bindings/media/qcom,venus-msm8916.yaml | 115 ++++++++++++++++++ > 1 file changed, 115 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,venus-msm8916.yaml Make the filename match the compatible. > > diff --git a/Documentation/devicetree/bindings/media/qcom,venus-msm8916.yaml b/Documentation/devicetree/bindings/media/qcom,venus-msm8916.yaml > new file mode 100644 > index 000000000000..f82a8d968202 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,venus-msm8916.yaml > @@ -0,0 +1,115 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/media/qcom,venus-msm8916.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; > + > +title: Qualcomm Venus video encode and decode accelerators > + > +maintainers: > + - Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > + > +description: | > + The Venus IP is a video encode and decode accelerator present > + on Qualcomm platforms > + > +properties: > + compatible: > + enum: > + - qcom,msm8916-venus Not likely a 2nd compatible here?, so you can use 'const' instead. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + clocks: > + maxItems: 3 > + > + clock-names: > + maxItems: 3 Don't need this. Implied with the length of 'items'. > + items: > + - const: core > + - const: iface > + - const: bus > + > + iommus: > + minItems: 1 > + maxItems: 20 > + > + memory-region: > + maxItems: 1 > + > + video-decoder: > + type: object > + > + properties: > + compatible: > + const: "venus-decoder" > + > + required: > + - compatible additionalProperties: false > + > + video-encoder: > + type: object > + > + properties: > + compatible: > + const: "venus-encoder" > + > + required: > + - compatible Here too. > + > + video-firmware: > + type: object > + > + description: | > + Firmware subnode is needed when the platform does not > + have TrustZone. > + > + properties: > + iommus: > + minItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - power-domains > + - clocks > + - clock-names > + - iommus > + - memory-region > + - video-decoder > + - video-encoder > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,gcc-msm8916.h> > + > + video-codec@1d00000 { > + compatible = "qcom,msm8916-venus"; > + reg = <0x01d00000 0xff000>; > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&gcc GCC_VENUS0_VCODEC0_CLK>, > + <&gcc GCC_VENUS0_AHB_CLK>, > + <&gcc GCC_VENUS0_AXI_CLK>; > + clock-names = "core", "iface", "bus"; > + power-domains = <&gcc VENUS_GDSC>; > + iommus = <&apps_iommu 5>; > + memory-region = <&venus_mem>; > + > + video-decoder { > + compatible = "venus-decoder"; > + }; > + > + video-encoder { > + compatible = "venus-encoder"; > + }; > + }; > -- > 2.17.1 >