On Wed, Dec 18, 2019 at 11:05:15AM -0600, Rob Herring wrote: > On Thu, Dec 12, 2019 at 11:16:47AM +0100, Linus Walleij wrote: > > Hi Dan, > > > > thanks for your patch! > > > > On Wed, Dec 11, 2019 at 2:20 AM Dan Robertson <dan@xxxxxxxxxxxxxxx> wrote: > > > > > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power > > > accelerometer sensor. > > > > > > Signed-off-by: Dan Robertson <dan@xxxxxxxxxxxxxxx> > > (...) > > > > > + Specifications about the sensor can be found at: > > > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf > > > > As can be seen in page 113 in the manual this component > > has VDD and VDDIO supplies and sooner or later someone > > is going to have to model that so I'd say add vdd-supply and > > vddio-supply regulator phandles as optional to the component > > already from start. > > And interrupts too. Doesn't matter what the driver currently uses. Will do. I plan to work on adding support for interrupts in a follow-up patchset, but I'll add this to the devicetree documentation. Cheers, - Dan