On Sat, Dec 14, 2019 at 09:21:45AM +0100, Sam Ravnborg wrote: > Hi Allen. > > On Tue, Dec 10, 2019 at 01:53:41PM +0800, allen wrote: > > Add a DT binding documentation for IT6505. > > > > Signed-off-by: Allen Chen <allen.chen@xxxxxxxxxx> > > Signed-off-by: Pi-Hsun Shih <pihsun@xxxxxxxxxxxx> > > --- > > .../bindings/display/bridge/ite,it6505.yaml | 99 ++++++++++++++++++++++ > > 1 file changed, 99 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > new file mode 100644 > > index 00000000..23a106a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml > > @@ -0,0 +1,99 @@ > > +# SPDX-License-Identifier: GPL-2.0 > Please dual license new bindings like this: > > (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/ite,it6505.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ITE it6505 Device Tree Bindings > > + > > +maintainers: > > + - Allen Chen <allen.chen@xxxxxxxxxx> > > + > > +description: | > > + The IT6505 is a high-performance DisplayPort 1.1a transmitter, > > +fully compliant with DisplayPort 1.1a, HDCP 1.3 specifications. > > +The IT6505 supports color depth of up to 36 bits (12 bits/color) > > +and ensures robust transmission of high-quality uncompressed video > > +content, along with uncompressed and compressed digital audio content. > Can we get consistent indent of the text here. Pretty sure that's not even valid YAML. > With this fixed: > Acked-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > + > > + Aside from the various video output formats supported, the IT6505 > > +also encodes and transmits up to 8 channels of I2S digital audio, > > +with sampling rate up to 192kHz and sample size up to 24 bits. > > +In addition, an S/PDIF input port takes in compressed audio of up to > > +192kHz frame rate. > > + > > + Each IT6505 chip comes preprogrammed with an unique HDCP key, > > +in compliance with the HDCP 1.3 standard so as to provide secure > > +transmission of high-definition content. Users of the IT6505 need not > > +purchase any HDCP keys or ROMs. > > + > > +properties: > > + compatible: > > + const: ite,it6505 > > + > > + reg: > > + - maxItems: 1 > > + - description: i2c address of the bridge And this is not valid json-schema. The '-' means list and properties aren't lists. Run 'make dt_binding_check' and fix all the errors. See Documentation/devicetree/bindings/writing-schema.rst. > > + > > + ovdd-supply: > > + - maxItems: 1 > > + - description: I/O voltage > > + > > + pwr18-supply: > > + - maxItems: 1 > > + - description: core voltage > > + > > + interrupts: > > + - maxItems: 1 > > + - description: interrupt specifier of INT pin > > + > > + reset-gpios: > > + - maxItems: 1 > > + - description: gpio specifier of RESET pin > > + > > + hpd-gpios: Is HPD attached to the DP bridge or the DP connector. For the latter, then this property goes in a connector node. > > + - maxItems: 1 > > + - description: > > + - Hotplug detect GPIO > > + - Indicates which GPIO should be used for hotplug detection > > + > > + extcon: Don't use extcon. Deprecated. > > + - maxItems: 1 > > + - description: extcon specifier for the Power Delivery > > + > > + port: > > + - type: object > > + - description: A port node pointing to DPI host port node > > + > > +required: > > + - compatible > > + - reg > > + - ovdd-supply > > + - pwr18-supply > > + - interrupts > > + - reset-gpios > > + - hpd-gpios > > + - extcon > > + > > +examples: > > + - | > > + dp-bridge@5c { > > + compatible = "ite,it6505"; > > + interrupts = <152 IRQ_TYPE_EDGE_RISING 152 0>; > > + reg = <0x5c>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&it6505_pins>; > > + ovdd-supply = <&mt6358_vsim1_reg>; > > + pwr18-supply = <&it6505_pp18_reg>; > > + reset-gpios = <&pio 179 1>; > > + hpd-gpios = <&pio 9 0>; > > + extcon = <&usbc_extcon>; > > + > > + port { > > + it6505_in: endpoint { > > + remote-endpoint = <&dpi_out>; > > + }; > > + }; > > + }; > > + > > +---
