Hi,
On Wed, Dec 4, 2019 at 8:43 PM Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx> wrote:
>
> Add QUSB2 phy entries for SC7180 in device tree bindings.
>
> Signed-off-by: Sandeep Maheswaram <sanm@xxxxxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/phy/qcom-qusb2-phy.yaml | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.yaml
> index 3ef94bc..5eff9016 100644
> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.yaml
> @@ -18,6 +18,7 @@ properties:
> enum:
> - qcom,msm8996-qusb2-phy
> - qcom,msm8998-qusb2-phy
> + - qcom,sc7180-qusb2-phy
> - qcom,sdm845-qusb2-phy
I would propose that we add generic PHY v2 tagging here, like this:
properties:
compatible:
anyOf:
- items:
- const: qcom,msm8996-qusb2-phy
- items:
- const: qcom,msm8998-qusb2-phy
- items:
# Suggested to also add "qcom,qusb2-v2-phy" as below.
- const: qcom,sdm845-qusb2-phy
- items:
- enum:
- qcom,sc7180-qusb2-phy
- qcom,sdm845-qusb2-phy
- const: qcom,qusb2-v2-phy
Given that this PHY has a fairly linear versioning within Qualcomm
(right?) this should make sense and should make code / adding new
device trees easier. This is probably better than what I suggested in
the driver review [1] where I suggested that the compatible for sc7180
should be:
compatible: "qcom,sc7180-qusb2-phy", "qcom,sdm845-qusb2-phy"
> reg:
> @@ -66,7 +67,7 @@ properties:
> It is a 6 bit value that specifies offset to be
> added to PHY refgen RESCODE via IMP_CTRL1 register. It is a PHY
> tuning parameter that may vary for different boards of same SOC.
> - This property is applicable to only QUSB2 v2 PHY (sdm845).
> + This property is applicable to only QUSB2 v2 PHY (sc7180, sdm845).
If you add my tagging, change this and other similar to just remove sdm845.
[1] https://lore.kernel.org/r/CAD=FV=W_z=_j==DSFbtCmTihmSyRtH85VnKpw03E=gATcqJx2Q@xxxxxxxxxxxxxx
-Doug
