>-----Original Message----- >From: Vinod Koul <vkoul@xxxxxxxxxx> >Sent: 2019年12月18日 14:27 >To: Peng Ma <peng.ma@xxxxxxx> >Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx; Leo >Li <leoyang.li@xxxxxxx>; dan.j.williams@xxxxxxxxx; Robin Gong ><yibin.gong@xxxxxxx>; dmaengine@xxxxxxxxxxxxxxx; >devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; >linux-arm-kernel@xxxxxxxxxxxxxxxxxxx >Subject: [EXT] Re: [v5 1/3] dmaengine: fsl-edma: Add eDMA support for QorIQ >LS1028A platform > >Caution: EXT Email > >On 12-12-19, 03:38, Peng Ma wrote: >> Our platforms(such as LS1021A, LS1012A, LS1043A, LS1046A, LS1028A) >> with below registers(CHCFG0 - CHCFG15) of eDMA as follows: >> *-----------------------------------------------------------* >> | Offset | OTHERS | >LS1028A | >> |--------------|--------------------|-----------------------| >> | 0x0 | CHCFG0 | CHCFG3 | >> |--------------|--------------------|-----------------------| >> | 0x1 | CHCFG1 | CHCFG2 | >> |--------------|--------------------|-----------------------| >> | 0x2 | CHCFG2 | CHCFG1 | >> |--------------|--------------------|-----------------------| >> | 0x3 | CHCFG3 | CHCFG0 | >> |--------------|--------------------|-----------------------| >> | ... | ...... | ...... | >> |--------------|--------------------|-----------------------| >> | 0xC | CHCFG12 | CHCFG15 | >> |--------------|--------------------|-----------------------| >> | 0xD | CHCFG13 | CHCFG14 | >> |--------------|--------------------|-----------------------| >> | 0xE | CHCFG14 | CHCFG13 | >> |--------------|--------------------|-----------------------| >> | 0xF | CHCFG15 | CHCFG12 | >> *-----------------------------------------------------------* >> >> This patch is to improve edma driver to fit LS1028A platform. > Hi Vinod >Applied this and patch 3, thanks > [Peng Ma] Many thanks. >Btw pls send bindings as patch1 and driver changes as patch2. [Peng Ma] I don't understand this sentence, Please give me more information. As I know patch1 is driver changes, patch2 is dts changes, patch3 is binding changes. You accepted patch1 and patch3, I am puzzled for patch2 and your comments. Best Regards, Peng >-- >~Vinod