Hi Bibby, On Fri, 2019-12-06 at 12:02 +0800, Bibby Hsieh wrote: > On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > > Return error code to client if send message fail, > > so that client has chance to error handling. > > > This patches seems like a fix patch. > Please add fixes, thanks. > > Bibby Do you mean add *fixes* in title? How about *fixes flush async function return error when send fail* ? Regards, Dennis > > Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@xxxxxxxxxxxx> > > --- > > drivers/soc/mediatek/mtk-cmdq-helper.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > > index 274f6f311d05..8421b4090304 100644 > > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > > @@ -353,11 +353,11 @@ int cmdq_pkt_flush_async(struct cmdq_pkt *pkt, cmdq_async_flush_cb cb, > > spin_unlock_irqrestore(&client->lock, flags); > > } > > > > - mbox_send_message(client->chan, pkt); > > + err = mbox_send_message(client->chan, pkt); > > /* We can send next packet immediately, so just call txdone. */ > > mbox_client_txdone(client->chan, 0); > > > > - return 0; > > + return err; > > } > > EXPORT_SYMBOL(cmdq_pkt_flush_async); > > > >
