Re: [PATCH v5 5/5] net: dsa: add support for Atheros AR9331 built-in switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 16, 2019 at 08:44:03AM +0100, Oleksij Rempel wrote:
> Provide basic support for Atheros AR9331 built-in switch. So far it
> works as port multiplexer without any hardware offloading support.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> +
> +/* dummy reg to change page */
> +#define AR9331_SW_REG_PAGE			BIT(18)

Nit pick: It seems odd to define a register number using a BIT macro.

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux