Hi, On 11/26/19 8:50 PM, Andrew-sh.Cheng wrote: > From: "Andrew-sh.Cheng" <andrew-sh.cheng@xxxxxxxxxxxx> > > This adds dt-binding documentation of cci devfreq > for Mediatek MT8183 SoC platform. > > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@xxxxxxxxxxxx> > --- > .../bindings/devfreq/mt8183-cci-devfreq.txt | 20 ++++++++++++++++++++ mt8183-cci.txt is better without 'devfreq' word. I recommend to make the binding document with yaml. You can refer to the example[1] [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-next&id=6ad0b4fb960c3bc32034d8f3ec7609c8bcb8d9a4 > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > > diff --git a/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > new file mode 100644 > index 000000000000..a65a70bb9f09 > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/mt8183-cci-devfreq.txt > @@ -0,0 +1,20 @@ > +* Mediatek Cache Coherent Interconnect(CCI) frequency device recommend to add the more detailed description of what is the role of this driver. > + > +Required properties: > +- compatible: should contain "mediatek,mt8183-cci" for frequency scaling of CCI > +- clocks: for frequency scaling of CCI > +- clock-names: for frequency scaling of CCI driver to reference > +- regulator: for voltage scaling of CCI > +- operating-points-v2: for frequency scaling of CCI opp table > + > +Example: > + cci: cci { > + compatible = "mediatek,mt8183-cci"; > + clocks = <&apmixedsys CLK_APMIXED_CCIPLL>; > + clock-names = "cci_clock"; Recommend to use 'cci' without '_clock' because we can know that it's clock name event if '_clock'. > + operating-points-v2 = <&cci_opp>; > + }; > + > + &cci { > + proc-supply = <&mt6358_vproc12_reg>; > + }; > \ No newline at end of file > -- Best Regards, Chanwoo Choi Samsung Electronics
