Hi Miquel.
On Fri, Dec 13, 2019 at 07:23:25PM +0100, Miquel Raynal wrote:
> Add support for the Satoz SAT050AT40H12R2 RGB panel.
Google failed to find this display - do you have any pointers to
datasheet?
This turned up: SAT050AT40H12B2
But I failed to find any data sheet.
I wonder if there is any typical, min, max timings - so we could use
display_timing rather than display_mode.
Before the compatible is documented the patch will not be applied.
So you need to submit a binding document too,
which must be in meta-schema syntax (.yaml).
Sam
>
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 15dd495c347d..8ae98437cbba 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2557,6 +2557,30 @@ static const struct panel_desc samsung_ltn140at29_301 = {
> },
> };
>
> +static const struct drm_display_mode satoz_sat050at40h12r2_mode = {
> + .clock = 33300,
> + .hdisplay = 800,
> + .hsync_start = 800 + 210,
> + .hsync_end = 800 + 210 + 20,
> + .htotal = 800 + 210 + 420 + 46,
> + .vdisplay = 480,
> + .vsync_start = 480 + 23,
> + .vsync_end = 480 + 23 + 10,
> + .vtotal = 480 + 23 + 10 + 22,
> + .vrefresh = 60,
> +};
> +
> +static const struct panel_desc satoz_sat050at40h12r2 = {
> + .modes = &satoz_sat050at40h12r2_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 108,
> + .height = 65,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> +};
> +
> static const struct drm_display_mode sharp_ld_d5116z01b_mode = {
> .clock = 168480,
> .hdisplay = 1920,
> @@ -3357,6 +3381,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "samsung,ltn140at29-301",
> .data = &samsung_ltn140at29_301,
> + }, {
> + .compatible = "satoz,sat050at40h12r2",
> + .data = &satoz_sat050at40h12r2,
> }, {
> .compatible = "sharp,ld-d5116z01b",
> .data = &sharp_ld_d5116z01b,
> --
> 2.20.1
