Re: [PATCH] dt-bindings: interconnect: Convert Allwinner MBUS controller to a schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 13, 2019 at 3:45 PM Maxime Ripard <maxime@xxxxxxxxxx> wrote:
>
> The older Allwinner SoCs have an MBUS controller that is used by Linux,
> with a matching Device Tree binding.
>
> Now that we have the DT validation in place, let's convert the device tree
> bindings for that controller over to a YAML schemas.
>
> Signed-off-by: Maxime Ripard <maxime@xxxxxxxxxx>
> ---
>  .../arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 65 +++++++++++++++++++
>  .../bindings/arm/sunxi/sunxi-mbus.txt         | 37 -----------
>  2 files changed, 65 insertions(+), 37 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>  delete mode 100644 Documentation/devicetree/bindings/arm/sunxi/sunxi-mbus.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> new file mode 100644
> index 000000000000..9370e64992dd
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
> @@ -0,0 +1,65 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/sunxi/allwinner,sun4i-a10-mbus.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Allwinner Memory Bus (MBUS) controller
> +
> +maintainers:
> +  - Chen-Yu Tsai <wens@xxxxxxxx>
> +  - Maxime Ripard <mripard@xxxxxxxxxx>
> +
> +description: |
> +  The MBUS controller drives the MBUS that other devices in the SoC
> +  will use to perform DMA. It also has a register interface that
> +  allows to monitor and control the bandwidth and priorities for
> +  masters on that bus.
> +
> +  Each device having to perform their DMA through the MBUS must have
> +  the interconnects and interconnect-names properties set to the MBUS
> +  controller and with "dma-mem" as the interconnect name.
> +
> +properties:
> +  "#interconnect-cells":
> +    const: 1
> +    description:
> +      The content of the cell is the MBUS ID.
> +
> +  compatible:
> +    enum:
> +      - allwinner,sun5i-a13-mbus
> +      - allwinner,sun8i-h3-mbus

Is there a driver in mainline  for it?

Thx,
Yangtao

> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  dma-ranges:
> +    description:
> +      See section 2.3.9 of the DeviceTree Specification.
> +
> +required:
> +  - "#interconnect-cells"
> +  - compatible
> +  - reg
> +  - clocks
> +  - dma-ranges
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/sun5i-ccu.h>
> +
> +    mbus: dram-controller@1c01000 {
> +        compatible = "allwinner,sun5i-a13-mbus";
> +        reg = <0x01c01000 0x1000>;
> +        clocks = <&ccu CLK_MBUS>;
> +        dma-ranges = <0x00000000 0x40000000 0x20000000>;
> +        #interconnect-cells = <1>;
> +    };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/arm/sunxi/sunxi-mbus.txt b/Documentation/devicetree/bindings/arm/sunxi/sunxi-mbus.txt
> deleted file mode 100644
> index 2005bb486705..000000000000
> --- a/Documentation/devicetree/bindings/arm/sunxi/sunxi-mbus.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -Allwinner Memory Bus (MBUS) controller
> -
> -The MBUS controller drives the MBUS that other devices in the SoC will
> -use to perform DMA. It also has a register interface that allows to
> -monitor and control the bandwidth and priorities for masters on that
> -bus.
> -
> -Required properties:
> - - compatible: Must be one of:
> -       - allwinner,sun5i-a13-mbus
> -       - allwinner,sun8i-h3-mbus
> - - reg: Offset and length of the register set for the controller
> - - clocks: phandle to the clock driving the controller
> - - dma-ranges: See section 2.3.9 of the DeviceTree Specification
> - - #interconnect-cells: Must be one, with the argument being the MBUS
> -   port ID
> -
> -Each device having to perform their DMA through the MBUS must have the
> -interconnects and interconnect-names properties set to the MBUS
> -controller and with "dma-mem" as the interconnect name.
> -
> -Example:
> -
> -mbus: dram-controller@1c01000 {
> -       compatible = "allwinner,sun5i-a13-mbus";
> -       reg = <0x01c01000 0x1000>;
> -       clocks = <&ccu CLK_MBUS>;
> -       dma-ranges = <0x00000000 0x40000000 0x20000000>;
> -       #interconnect-cells = <1>;
> -};
> -
> -fe0: display-frontend@1e00000 {
> -       compatible = "allwinner,sun5i-a13-display-frontend";
> -       ...
> -       interconnects = <&mbus 19>;
> -       interconnect-names = "dma-mem";
> -};
> --
> 2.23.0
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux