Hi Boris, Thank you for the patch. On Fri, Dec 13, 2019 at 01:54:12PM +0100, Boris Brezillon wrote: > Document the Rockchip RK3399 Video Decoder bindings. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > --- > Changes in v3: > * Fix dtbs_check failures > --- > .../bindings/media/rockchip,vdec.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/rockchip,vdec.yaml > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > new file mode 100644 > index 000000000000..7167c3d6a389 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,vdec.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip Video Decoder (VDec) Device Tree Bindings > + > +maintainers: > + - Heiko Stuebner <heiko@xxxxxxxxx> > + > +description: |- > + The Rockchip rk3399 has a stateless Video Decoder that can decodes H.264, > + HEVC an VP9 streams. > + > +properties: > + compatible: > + const: rockchip,rk3399-vdec > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: The Video Decoder AXI interface clock > + - description: The Video Decoder AHB interface clock > + - description: The Video Decoded CABAC clock > + - description: The Video Decoder core clock > + > + clock-names: > + items: > + - const: aclk How about calling it "axi" ? None of the other clock names have "clk". > + - const: iface And "ahb" here, as the AXI interface clock is also an interface clock ? > + - const: cabac > + - const: core > + > + power-domains: > + maxItems: 1 > + > + iommus: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - power-domains > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + vdec: video-codec@ff660000 { > + compatible = "rockchip,rk3399-vdec"; > + reg = <0x0 0xff660000 0x0 0x400>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&cru ACLK_VDU>, <&cru HCLK_VDU>, > + <&cru SCLK_VDU_CA>, <&cru SCLK_VDU_CORE>; > + clock-names = "aclk", "iface", "cabac", "core"; > + power-domains = <&power RK3399_PD_VDU>; > + iommus = <&vdec_mmu>; > + }; > + > +... -- Regards, Laurent Pinchart
