Ok thanks for your review, I will do that. Regards, Clément Léger ----- On 13 Dec, 2019, at 09:59, Linus Walleij linus.walleij@xxxxxxxxxx wrote: > On Wed, Dec 4, 2019 at 11:10 AM Clement Leger <cleger@xxxxxxxxx> wrote: > >> Synopsys DWAPB IP includes support for pin control. This control is basic >> and allows to switch between a hardware and a software function. >> Software function is when driving GPIOs from IP and hardware is controlled >> by external signals. >> This serie export necessary interface to be able to move the driver to >> pinctrl folder and then implement the pinctrl support which is based on the >> digicolor driver. The idea is to avoid hardcoding pins in driver since >> this IP is a generic one available on multiple SoC. > > The overall approach is correct, just tidy up the patch series the > way indicated by Andy and we can probably proceed efficiently with > this. I will review the patch adding the pinctrl interfaces separately. > > Yours, > Linus Walleij
