On Thu, 2019-12-12 at 03:27 +0800, Andrew Lunn wrote: > > Do you also hint at using the same number of parameters for > > mt7531_ind_c22_phy_read() and mt7531_ind_c45_phy_read()? > > That is up to you. It just seems like your MDIO bus can do both C22 > and C45. And somebody might connect an external C45 PHY, so you might > as well support it. Yes, it is better to support external C45 PHY. Thanks for your advice. Landen > > Andrew