Hi Philipp. Thanks for your time. > On Dec 2, 2019, at 7:53 AM, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > > On Fri, 2019-11-29 at 10:38 +1030, Joel Stanley wrote: >> From: Brad Bishop <bradleyb@xxxxxxxxxxxxxxxxxx> >> >> The AST2600 SoC contains the same LPC register set as the AST2500. > > If the LPC register set is exactly the same, shouldn't AST2600 reuse the > AST2500 compatible, i.e.: > compatible = "aspeed,ast2600-lpc-reset", "aspeed,ast2500-lpc-reset"; > ? I’m not sure. I let what was already there be my guide - the ast2500 LPC registers are the same as the ast2400 as well and those got their own compatibles. Is there a guideline written down somewhere that backs your thinking up? thanks - brad