On Wed, 2019-12-11 at 00:51 +0800, Andrew Lunn wrote: > > + port@6 { > > + reg = <6>; > > + label = "cpu"; > > + ethernet = <&gmac0>; > > + phy-mode = "2500base-x"; > > + > > + fixed-link { > > + speed = <2500>; > > + full-duplex; > > + pause; > > + }; > > This fixed-link should not be needed. The DSA driver is supposed to > configure the CPU port to its fastest speed by default. 2500 is > the fastest speed a 2500Base-X link can do... I'll add the cpu port logic to use the fastest speed by default. It also needs to modify the mt753x_phylink_mac_config() logic. Landen > > Andrew