accidently send it only to Lee, that was unintended.
On Tue, 10 Dec 2019 09:13:51 +0000
Lee Jones <lee.jones@xxxxxxxxxx> wrote:
> On Fri, 29 Nov 2019, Andreas Kemnade wrote:
>
> > rn5t618 currently lacks irq handling. To prepare implementation
>
> "RN5T618"
> "IRQ"
>
> > in a rn5t618-irq.c, move main file to rn5t618-core.c
>
> Why do you *need* to call it "core"?
>
Well, the pattern is that irq stuff is in a separate file
for other mfds. And when I want to link things together to a rn5t618.[k]o
I think that none objects cannot be called rn5t618.o and so no source
file rn5t618.o. Am I wrong here? Of course if things can live in one file
this thing is not needed.
Regards,
Andreas
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > ---
> > drivers/mfd/Makefile | 2 ++
> > drivers/mfd/{rn5t618.c => rn5t618-core.c} | 0
> > 2 files changed, 2 insertions(+)
> > rename drivers/mfd/{rn5t618.c => rn5t618-core.c} (100%)
> >
> > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> > index c1067ea46204..110ea700231b 100644
> > --- a/drivers/mfd/Makefile
> > +++ b/drivers/mfd/Makefile
> > @@ -216,6 +216,8 @@ obj-$(CONFIG_MFD_PALMAS) += palmas.o
> > obj-$(CONFIG_MFD_VIPERBOARD) += viperboard.o
> > obj-$(CONFIG_MFD_RC5T583) += rc5t583.o rc5t583-irq.o
> > obj-$(CONFIG_MFD_RK808) += rk808.o
> > +
> > +rn5t618-objs := rn5t618-core.o
> > obj-$(CONFIG_MFD_RN5T618) += rn5t618.o
> > obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o sec-irq.o
> > obj-$(CONFIG_MFD_SYSCON) += syscon.o
> > diff --git a/drivers/mfd/rn5t618.c b/drivers/mfd/rn5t618-core.c
> > similarity index 100%
> > rename from drivers/mfd/rn5t618.c
> > rename to drivers/mfd/rn5t618-core.c
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog
>
Attachment:
pgpeN8htN8XlI.pgp
Description: OpenPGP digital signature
