Hi, Please ignore this patch for now. I forgot to add description for power-domain-names property for sdm845. Will fix that in next version. On 12/9/19 10:38 AM, Stanimir Varbanov wrote: > Describe an optional DT binding for sdm845 with power-domain-names > and clocks in Venus DT node. After that the binding for sdm845 will > have two options, the first will be to describe vcodec clocks and > pmdomains in (encoder and decoder) subnodes and the second will be > to describe vcodec clocks and pmdomains in the Venus DT node > (the parent). Both option will be handled in driver, and the second > one will give an opportunity to the driver to dynamically assign > vcodec pipelines for every given instance depending on its load. > > Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx> > --- > .../devicetree/bindings/media/qcom,venus.txt | 22 ++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/qcom,venus.txt b/Documentation/devicetree/bindings/media/qcom,venus.txt > index b602c4c025e7..69a104fcb8eb 100644 > --- a/Documentation/devicetree/bindings/media/qcom,venus.txt > +++ b/Documentation/devicetree/bindings/media/qcom,venus.txt > @@ -35,6 +35,21 @@ > - "iface" Video accelerator AHB clock > - "bus" Video accelerator AXI clock > - "mbus" Video MAXI clock > +- clock-names: > + Usage: required for sdm845 > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "core" Core video accelerator clock > + - "iface" Video accelerator AHB clock > + - "bus" Video accelerator AXI clock > +- clock-names: > + Usage: optional for sdm845 > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "vcodec0_core" Codec0 core clock > + - "vcodec0_bus" Codec0 AXI clock > + - "vcodec1_core" Codec1 core clock > + - "vcoded1_bus" Codec1 AXI clock > - power-domains: > Usage: required > Value type: <prop-encoded-array> > @@ -72,7 +87,12 @@ Every of video-encoder or video-decoder subnode should have: > Value type: <stringlist> > Definition: Should contain the following entries: > - "core" Subcore video accelerator clock > - > +- clock-names: > + Usage: required for sdm845 > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "core" Video codec accelerator clock > + - "bus" Video codec AXI clock > - power-domains: > Usage: required for msm8996 > Value type: <prop-encoded-array> > -- regards, Stan