Re: [PATCH] arm64: dts: allwinner: a64: set GPU clock to 432 MHz

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 9, 2019 at 12:03 PM Maxime Ripard <mripard@xxxxxxxxxx> wrote:
>
> Hi,
>
> On Mon, Dec 02, 2019 at 06:14:20PM -0800, Vasily Khoruzhick wrote:
> > That's what BSP kernel sets it to and it seems to work fine.
> >
> > Signed-off-by: Vasily Khoruzhick <anarsoul@xxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > index 27e48234f1c2..0051f39b3d98 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -976,6 +976,9 @@ mali: gpu@1c40000 {
> >                       clocks = <&ccu CLK_BUS_GPU>, <&ccu CLK_GPU>;
> >                       clock-names = "bus", "core";
> >                       resets = <&ccu RST_BUS_GPU>;
> > +
> > +                     assigned-clocks = <&ccu CLK_GPU>;
> > +                     assigned-clock-rates = <432000000>;
> >               };
>
> This doesn't really guarantee anything. If the GPU needs to remain at
> that rate, it should be set in the driver. I just saw that you did
> send a PR in github, I just merged it.

Lima doesn't set GPU frequency at all since it's different for
different SoCs and we don't support operation points nor frequency
scaling yet.

So this change effectively sets GPU frequency to 432MHz on A64 when using lima.

>
> Maxime



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux