Hi Robin, On Mon, 9 Dec 2019 at 18:59, Robin Murphy <robin.murphy@xxxxxxx> wrote: > > On 06/12/2019 6:45 pm, Anand Moon wrote: > > Most of the RK3399 SBC boards do not perform clean > > shutdown and clean reboot. > > FWIW reboot problems on RK3399 have been tracked down to issues in > upstream ATF, and are unrelated to the PMIC. Yes I am aware of this changes. But, I have tired to study *RK808 datasheet V1.4* [0] below section *5.2.3 Power Channel Control/Monitor Registers* for clean reboot I was going to try disable some bit in below into reboot handle in the future patch. DCDC_EN_REG SLEEP_SET_OFF_REG1 SLEEP_SET_OFF_REG2 DCDC_UV_STS_REG I was going see if this helps to do clean reboot. further more use this in suspend/resume operation. [0] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf But I feed that their is some more issue with related to mmc or PCIe not able to cleanly release the resources while reboot which caused then to disable after reboot. > > > These patches try to help resolve the issue with proper > > shutdown by turning off the PMIC. > > As mentioned elsewhere[1], although this is what the BSP kernel seems to > do, and in practice it's unlikely to matter for the majority of devboard > users like you and me, I still feel a bit uncomfortable with this > solution for systems using ATF as in principle the secure world might > want to know about orderly shutdowns, and this effectively makes every > shutdown an unexpected power loss from secure software's point of view. > > Robin. > > [1] > http://lists.infradead.org/pipermail/linux-rockchip/2019-December/028183.html > Yes I have follow the mailing list and I read this thread. I am not aware of ATF complete architecture. -Anand