On Wed, Nov 27, 2019 at 02:23:04PM +0100, Marco Felsch wrote:
> There was a bug within the driver since commit f889beaaab1c ("Input:
> da9063 - report KEY_POWER instead of KEY_SLEEP during power
> key-press"). Since we fixed the bug the KEY_POWER will be reported
> always so we need to adapt the dt-bindings too. Make the description
> more precise while on it.
>
> Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
> ---
> v2:
> - change description according Dmitry's suggestion.
>
> Documentation/devicetree/bindings/input/da9062-onkey.txt | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/da9062-onkey.txt b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> index 0005b2bdcdd7..9f895454179d 100644
> --- a/Documentation/devicetree/bindings/input/da9062-onkey.txt
> +++ b/Documentation/devicetree/bindings/input/da9062-onkey.txt
> @@ -15,9 +15,8 @@ Required properties:
>
> Optional properties:
>
> -- dlg,disable-key-power : Disable power-down using a long key-press. If this
> - entry exists the OnKey driver will remove support for the KEY_POWER key
> - press when triggered using a long press of the OnKey.
> +- dlg,disable-key-power : If this property is present, the host will not be
> + issuing shutdown command over I2C in response to a long key-press.
This seems odd. Typically a long key press is used when the system is
locked up and would have to be a h/w mechanism.
Also, the new wording sounds like s/w policy, not h/w configuration.
What the OS does in response to KEY_POWER doesn't belong in DT.
>
> - dlg,key-opmode : Set the nONKEY behaviour. This value is initial set by the
> otp values. See nONKEY_PIN register description for more information.
> --
> 2.20.1
>
