On 05/12/2019 10:46, Laurent Pinchart wrote: > Hi Jyri, > > Thank you for the patch. > > On Wed, Dec 04, 2019 at 07:53:11PM +0200, Jyri Sarha wrote: >> The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc >> is fully capable of using generic drm panels like panel-simple and >> panel-common binding. However, the obsolete binding is still widely >> used in many mainline supported platforms that I do not have access to >> and who knows how many custom platforms. So I am afraid we have to >> keep the old bundled tilcdc panel driver around. >> >> Signed-off-by: Jyri Sarha <jsarha@xxxxxx> >> --- >> Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> index 808216310ea2..54963f9173cc 100644 >> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt >> @@ -1,5 +1,11 @@ >> Device-Tree bindings for tilcdc DRM generic panel output driver >> >> +NOTE: This binding (and the related driver) is obsolete and should not >> + be used anymore. Please refer to drm panel-common binding (and >> + to a generic drm panel driver like panel-simple). >> + Documentation/devicetree/bindings/display/panel/panel-common.yaml >> + (drivers/gpu/drm/panel/panel-simple.c) >> + > > How about adding a WARN_ON() in the code when this binding is used ? > This could help getting those platforms converted. > I don't see why not, I'll add that. Thanks Jyro >> Required properties: >> - compatible: value should be "ti,tilcdc,panel". >> - panel-info: configuration info to configure LCDC correctly for the panel > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
