Hello Mark, On Tue, Dec 3, 2019, Mark Brown wrote: > > +static void spibsc_write(struct spibsc_priv *sbsc, int reg, u32 val) > > +{ > > + iowrite32(val, sbsc->base + reg); > > +} > > +static void spibsc_write8(struct spibsc_priv *sbsc, int reg, u8 val) > > Looking at a bunch of the stuff here it looks like you could benefit from > regmap, it's got lots of debug infrastructure. Thank you for the suggestion, but I looked into using regmap, and there are a lot of drivers that use it, but I don't think it's going to work well for me. Regmap assumes that all the registers will be the same size. I have to have functions that write with different widths (8/16/32) for a reason. Chris