On Wed, Nov 20, 2019 at 12:28:16AM +0530, Jagan Teki wrote: > Though the ROC-PC is manufactured by firefly, it is co-designed > by libretch like other Libretech computer boards from allwinner, > amlogic does. > > It is always meaningful to keep maintain those vendors who are > part of design participation, so add libretech roc-pc compatible > with existing binding. Maybe so, but this is pretty pointless if it's not different h/w. Compatible strings are simply a h/w identifier. > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index f7470ed1e17d..45728fd22af8 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -100,6 +100,7 @@ properties: > - description: Firefly ROC-RK3399-PC > items: > - enum: > + - libretech,roc-rk3399-pc > - firefly,roc-rk3399-pc > - firefly,roc-rk3399-pc-mezzanine This doesn't match your change in the dts. file. The schema says there are 2 strings with the first one being 1 of these 3. > - const: rockchip,rk3399 > -- > 2.18.0.321.gffc6fa0e3 >
