Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 2, 2019 at 9:02 AM Mohammad Rasim
<mohammad.rasim96@xxxxxxxxx> wrote:
>
> On 19/12/01 11:21PM, Martin Blumenstingl wrote:
> > [...]
> > > +       leds {
> > > +               compatible = "gpio-leds";
> > > +               status {
> > > +                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
> > > +                       default-state = "off";
> > > +                       color = <LED_COLOR_ID_RED>;
> > > +                       function = LED_FUNCTION_STATUS;
> > why is LED_FUNCTION_STATUS not enclosed in <> like color above?
> >
> Well, the examples in the documentation enclose the color and don't
> enclose function
> https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140
sorry for the noise, only now I realize that the LED_FUNCTION_*s are
string definitions and not numeric values
in this case all is fine

I learnt something new today ;)


Martin



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux