On Mon, 2 Dec 2019 19:03:36 +0200 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > > + /** > > + * @atomic_check: > > + * > > + * This method is responsible for checking bridge state correctness. > > + * It can also check the state of the surrounding components in chain > > + * to make sure the whole pipeline can work properly. > > As explained in the review of the RFC, I think it's a mistake not to > define the semantics of this operation precisely, and in particular not > to define explictly what parameters bridge drivers are allowed to modify > here. I however don't want to make this a prerequisite for your series, > so > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > but I'm sure we'll regret this later when different bridges will have > slightly incompatible implementations. Nothing prevents us from working on this clarification after the patch series has been merged. I just said I couldn't come up with a good set of rules on my own, as I don't really know what bridge->mode_fixup() allows us to modify in the first place.
