Hi Tomi,
Thank you for the patch.
On Thu, Nov 14, 2019 at 11:39:50AM +0200, Tomi Valkeinen wrote:
> The panel datasheet says that the panel samples at falling edge, but
> does not say anything about h/v sync signals. Testing shows that if the
> sync signals are driven on falling edge, the picture on the panel will
> be slightly shifted right.
>
> Setting sync drive edge to the same as data drive edge fixes this issue.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
I don't have access to the documentation, but this makes sense, so
Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 5d487686d25c..0784536ae6af 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2397,7 +2397,8 @@ static const struct panel_desc osddisplays_osd070t1718_19ts = {
> .height = 91,
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> - .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
> + DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE,
> .connector_type = DRM_MODE_CONNECTOR_DPI,
> };
>
--
Regards,
Laurent Pinchart
