On 04/30/2014 07:30 PM, Dmitry Torokhov wrote: > Hi Roger, > > On Wed, Apr 30, 2014 at 03:36:26PM +0300, Roger Quadros wrote: > >> static int pixcir_i2c_ts_remove(struct i2c_client *client) >> @@ -198,10 +194,8 @@ static int pixcir_i2c_ts_remove(struct i2c_client *client) >> >> tsdata->exiting = true; >> mb(); >> - free_irq(client->irq, tsdata); >> >> input_unregister_device(tsdata->input); > > There is no need to call input_unregister_device for managed input > devices. OK. I'll remove that. > >> - kfree(tsdata); >> >> return 0; >> } cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html