Hi Adam, On Fri, Nov 29, 2019 at 8:41 PM Adam Ford <aford173@xxxxxxxxx> wrote: > + > + gpc: gpc@303a0000 { > + compatible = "fsl,imx8mm-gpc"; You could do like this instead: compatible = "fsl,imx8mm-gpc", "fsl,imx8mq-gpc"; and then you don't need patch 1/2. Also, "fsl,imx8mm-gpc" needs to be documented.