Hi Tomasz, On Fri, May 2, 2014 at 2:58 AM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > On 24.04.2014 15:03, Shaik Ameer Basha wrote: >> >> Many changes/fixes have been identified for clock file for exynos5420. >> These include correct parents, bit fields, new clocks etc. Existing >> files needs some correction in terms of names of the clock and >> indentation. These issues are addressed in this patch series. It also >> replaces the usage of enums with macro as clock ids. >> >> This patch series is rebased on, >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git:master >> >> This patch is also dependent on the following patch. >> ARM: dts: add dt node for sss module for exynos5250/5420 > > > Also a general comment to all the patches. Please assign clock IDs for all > the clocks being added. In general, all the defined clocks should have clock > IDs defined to let them be accessed from Device Tree, for example in case of > DT clock initialization that is being worked on right now. Ok. Will take care of this in next series. Regards, Shaik > > Best regards, > Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html