On 19-11-29 09:25, Linus Walleij wrote: > On Wed, Nov 27, 2019 at 2:59 PM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote: > > > Each regulator can be enabeld/disabled by the internal pmic state > > machine or by a gpio input signal. Typically the OTP configures the > > regulators to be enabled/disabled on a specific sequence number which is > > most the time fine. Sometimes we need to reconfigure that due to a PCB > > bug. This patch adds the support to disable/enable the regulator based > > on a gpio input signal. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > Overall I think this is fine, it's a solid use case that need to be > supported. > > > + struct reg_field ena_gpi; > > Maybe just add some doc comment to this struct member? Yes, I can do that. > IIUC it is a general purpose input that can be configured > such that it will enable one of the DA9062 regulators when > asserted. (Correct?) Yes that's correct. Regards, Marco > Yours, > Linus Walleij > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
