On Thu, Nov 28, 2019 at 01:49:42PM +0100, Marco Felsch wrote: > On 19-11-28 11:46, Bartosz Golaszewski wrote: > > śr., 27 lis 2019 o 14:59 Marco Felsch <m.felsch@xxxxxxxxxxxxxx> napisał(a): > > > > > > Sometimes consumers needs to know the gpio-chip local gpio number of a > > > 'struct gpio_desc' for further configuration. This is often the case for > > > mfd devices. > > > > > > > We already have this support. It's just a matter of exporting it, so > > maybe adjust the commit message to not be confusing. > > Therefore I mentioned the consumers. > > > That being said: I'm not really a fan of this - the whole idea of gpio > > descriptors was to make them opaque and their hardware offsets > > irrelevant. :( > > I know therefore I added a driver local helper but this wasn't the way > Linus wanted to go.. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > > --- > > > drivers/gpio/gpiolib.c | 6 ++++++ > > > include/linux/gpio/consumer.h | 10 ++++++++++ > > > 2 files changed, 16 insertions(+) > > > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > > index 104ed299d5ea..7709648313fc 100644 > > > --- a/drivers/gpio/gpiolib.c > > > +++ b/drivers/gpio/gpiolib.c > > > @@ -4377,6 +4377,12 @@ int gpiod_count(struct device *dev, const char *con_id) > > > } > > > EXPORT_SYMBOL_GPL(gpiod_count); > > > > > > +int gpiod_to_offset(struct gpio_desc *desc) > > > > Maybe call it: gpiod_desc_to_offset()? > > The function name is proposed by Linus too so Linus what's your > oppinion? INAL (I'm not a Linus) but I wonder what the 'd' in gpiod stands for. Assuming it already meand "desc" I'd prefer gpiod_to_offset. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
