Hi Kieran, On Thu, Nov 28, 2019 at 11:55 AM <kbingham@xxxxxxxxxx> wrote: > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8f075b866aaf..640f099ff7fb 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8837,6 +8837,10 @@ S: Maintained > F: Documentation/admin-guide/jfs.rst > F: fs/jfs/ > > +JHD1313 LCD Dispaly driver Typo (and it should be all uppercase; and perhaps "Display" is not needed given LCD is there; but see also comments on the title below). Also missing the "S:" entry. > diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig > index b8313a04422d..cfc61c1abdee 100644 > --- a/drivers/auxdisplay/Kconfig > +++ b/drivers/auxdisplay/Kconfig > @@ -27,6 +27,18 @@ config HD44780 > kernel and started at boot. > If you don't understand what all this is about, say N. > > +config JHD1313 > + tristate "JHD1313 Character LCD support" > + depends on I2C > + select CHARLCD > + ---help--- > + Enable support for Character LCDs using a JHD1313 controller on I2C. > + The LCD is accessible through the /dev/lcd char device (10, 156). > + This code can either be compiled as a module, or linked into the > + kernel and started at boot. > + This supports the LCD panel on the Grove 16x2 LCD series. > + If you don't understand what all this is about, say N. Would it be useful/worth for users to put "Grove series" and/or "I2C" in the tristate title? (i.e. like the help section explains and also like the MODULE_DESCRIPTION says). > diff --git a/drivers/auxdisplay/jhd1313.c b/drivers/auxdisplay/jhd1313.c > new file mode 100644 > index 000000000000..abf270e128ac > --- /dev/null > +++ b/drivers/auxdisplay/jhd1313.c > @@ -0,0 +1,111 @@ > +// SPDX-License-Identifier: GPL-2.0+ > + Unconventional (AFAIK) empty line. Thanks for the driver! Cheers, Miguel
