Hi * Tomi Valkeinen <tomi.valkeinen@xxxxxx> [191127 12:59]: > Hi Tony, Thierry, Laurent, > > Any thoughts on the below points? > I think yet another option is to write some omap boot time quirks code, > which looks at the DT data, and changes the panel compatible string (for 1), > and removes the timings node (for 2). Nah, seems we can just update the compatible. > On 14/11/2019 11:39, Tomi Valkeinen wrote: > > 1) Panel driver is not probed. With omapdrm's panel-dpi, the match > > happened with "panel-dpi" compatible string. Now with panel-simple, the > > match should happen with the panel model compatible string, which is > > "osddisplays,osd057T0559-34ts" in the DT file. However, no such > > compatible exists in panel-simple. > > > > Interestingly, the actual panel at least on my EVMs and ePOSes is not > > osd057T0559-34ts, but osd070t1718-19ts. Also, I was unable to find any > > information about osd057T0559-34ts. I don't know the history with this, > > so it is possible that the early versions of the boards did have > > osd057T0559-34ts, but was later changed to osd070t1718-19ts. I guess you could keep the old compatible there too if really needed. But then again if the old compatible is known to be incorrect, it should be just updated. So it looks good to me for the dts changes. Do you want me to pick them into fixes as it seems that the panel driver fix is a separate issue? Regards, Tony
