Hi Linus, thanks for your feedback. On 19-11-27 14:35, Linus Walleij wrote: > On Wed, Nov 27, 2019 at 12:56 PM Marco Felsch <m.felsch@xxxxxxxxxxxxxx> wrote: > > > Currently the da9062 GPIO's aren't available. The patch adds the support > > to make these available by adding a gpio device with the corresponding > > irq resources. Furthermore the patch fixes a minor style issue for the > > onkey device. > > > > Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx> > > This is a regmap irqchip so I guess not much to say about it. > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > > HOWEVER: this looks very much hierarchical does it not? Yes it that's right and I converted it upon Bartosz comments. > I can clearly see that regmap's irqchip does not support > hierarchical interrupt domains, so we should just make a > mental note somewhere that "oh yeah and then one day > we should make regmap irqchips play well with hierarchical > interrupts". That's right, should I add this somewhere and if the answer is yes then where? Regards, Marco > > Yours, > Linus Walleij > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
