> > +static int aspeed_xdma_remove(struct platform_device *pdev) > > +{ > > + struct aspeed_xdma *ctx = platform_get_drvdata(pdev); > > + > > + gen_pool_free(ctx->vga_pool, (unsigned long)ctx->cmdq_vga_virt, > > + XDMA_CMDQ_SIZE); > > You've used devm_gen_pool_create(), so no need to explicitly free it. Sorry, disregard that, brain-fart. Andrew