Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:44:59PM +0200, Boris Brezillon wrote: > To iterate over all bridges attached to a specific encoder. > > Suggested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > --- > Changes in v3: > * None > > Changes in v2: > * New patch > --- > include/drm/drm_bridge.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 3ab16c95e59e..238e84ab63a3 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -441,6 +441,17 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) > struct drm_bridge, chain_node); > } > > +/** > + * for_each_bridge_in_chain() - Iterate over all bridges present in a chain The name doesn't match the macro below. Apart from that, Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > + * @encoder: the encoder to iterate bridges on > + * @bridge: a bridge pointer updated to point to the current bridge at each > + * iteration > + * > + * Iterate over all bridges present in the bridge chain attached to @encoder. > + */ > +#define drm_for_each_bridge_in_chain(encoder, bridge) \ > + list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) > + > bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > const struct drm_display_mode *mode, > struct drm_display_mode *adjusted_mode); -- Regards, Laurent Pinchart
